Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that /rooms/{roomId}/event/{eventId}'s 404 should be M_NOT_FOUND #2204

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Clarify that /rooms/{roomId}/event/{eventId}'s 404 should be M_NOT_FOUND #2204

merged 1 commit into from
Jul 31, 2019

Conversation

anoadragon453
Copy link
Member

No error code is specified for this endpoint's 404. State that it should be an M_NOT_FOUND.

@anoadragon453 anoadragon453 requested a review from turt2live July 31, 2019 14:12
turt2live
turt2live approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@anoadragon453 anoadragon453 merged commit af60889 into master Jul 31, 2019
@anoadragon453 anoadragon453 deleted the anoa/add_code_to_event_retrieval_endpoint branch July 31, 2019 14:14
@anoadragon453 anoadragon453 mentioned this pull request Jul 31, 2019
Merged
anoadragon453 added a commit that referenced this pull request Jul 31, 2019
@anoadragon453
Add missing changelog for #2204.
28596a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anoadragon453 @turt2live