Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the v1 IS API and replace most of it with v2 #2254

Merged
merged 5 commits into from
Aug 28, 2019

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Aug 28, 2019

This is part 1 of many, as shown by #2253

It may be easier to review this commit by commit. See 'docs' status check for what this looks like in the spec.

This PR handles deprecating the v1 API and replacing relevant bits with v2 stuff. This is an intermediary step to show at the spec level that v1 is truly deprecated, but does mean the whole thing is duplicated. The next IS spec version after this one is expected to delete the v1 stuff completely.

This PR intentionally does not handle defining the auth endpoints and how all that works in an effort to keep the PRs moderately reviewable. This PR does not include the new lookup API for the same reason.

Specs part of MSC2140.

Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm I think - I didn't see the terms & register stuff, is that coming separately?

Edit: as you say in the bug, yes it is

@turt2live
Copy link
Member Author

yup, writing it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants