Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec the v2 lookup API #2287

Merged
merged 3 commits into from
Sep 16, 2019
Merged

Spec the v2 lookup API #2287

merged 3 commits into from
Sep 16, 2019

Conversation

turt2live
Copy link
Member

Spec for MSC2134
See #2253

@turt2live turt2live mentioned this pull request Sep 10, 2019
Closed
10 tasks
@turt2live turt2live requested a review from a team September 10, 2019 02:00
@turt2live turt2live mentioned this pull request Sep 10, 2019
Merged
anoadragon453
anoadragon453 requested changes Sep 10, 2019
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job boiling down the points to make them easy to read and understand, and I believe you covered everything the MSC set out to. Some questions below.

api/identity/v2_lookup.yaml Show resolved Hide resolved
api/identity/v2_lookup.yaml Show resolved Hide resolved
specification/identity_service_api.rst Show resolved Hide resolved
specification/identity_service_api.rst Show resolved Hide resolved
@turt2live
Copy link
Member Author

@anoadragon453 ping

anoadragon453
anoadragon453 approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@turt2live turt2live merged commit 2c88f02 into master Sep 16, 2019
@turt2live turt2live deleted the travis/spec/lookup-v2 branch September 16, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
identity service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turt2live @anoadragon453