Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2689: Fix E2EE for guests #2689

Merged
merged 3 commits into from
Jul 29, 2020
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions proposals/2689-fix-e2ee-for-guests.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# MSC2689: Allow guests to operate in encrypted rooms

MSC751 suggested to allow guests to use several endpoints in order to allow guests to use E2EE.
awesome-michael marked this conversation as resolved.
Show resolved Hide resolved
I found that guests are able to join encrypted rooms and read messages from other members. But when the
guest wants to send an event into the room the client receives a "guest access not allowed" error
for the `/rooms/{room_id}/members` endpoint. I assume the client tries to read the list of room members
to prepare the encryption of the event for the present members. Tests with a patched Synapse showed that
allowing guests to use this endpoint results in a normal behaviour and enables guests to communicate in
encrypted rooms.


## Proposal

Allow guests to use the `GET /_matrix/client/r0/rooms/{room_id}/members` endpoint to enable them to
operate properly in encrypted rooms.


## Alternatives

The list of room members could also be read from the sync. However that would not work with Lazy Loading.