MSC2713: Remove deprecated v1 Identity Service API

[turt2live]

Rendered

[turt2live]

this doesn't require an implementation, so I vote this jumps straight into the request for comment period:

@mscbot fcp merge

[mscbot]

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

• @dbkr
• @uhoreg
• @turt2live
• @ara4n
• @anoadragon453
• @richvdh
• @erikjohnston
• @KitsuneRal

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

[richvdh]

I'd quite like to see some usage stats from the sydent access logs to help guide us on this.

[turt2live]

I'd quite like to see some usage stats from the sydent access logs to help guide us on this.

Have asked ops, which probably adds even more time for implementations to finally fix themselves.

[anoadragon453]

What do we do about /_matrix/identity/v2/pubkey/isvalid URLs stored in old m.room.membership events which homeservers MUST verify by making requests to (according to https://matrix.org/docs/spec/client_server/r0.6.1#id102)?

I suppose it's not the end of the world if those third-party invites just don't work?

[turt2live]

do you mean the v1 ones? Yes, I would expect that they'd break - servers shouldn't have been issuing v1-routed invites for a while now, so I'm less concerned about invites lost to time.

However, if there are modern invites using the v1 api - fml, we need to fix that.

[anoadragon453]

Looks like Synapse still (partially) does:

{
  "type": "m.room.third_party_invite",
  "sender": "@andrewm:amorgan.xyz",
  "content": {
    "display_name": "h...@g...",
    "public_keys": [
      {
        "key_validity_url": "https://vector.im/_matrix/identity/api/v1/pubkey/isvalid",
        "public_key": "ta8IQ0u1sp44HVpxdFOdS/bfwDjcy4xLFFlfY5KOA"
      },
      {
        "key_validity_url": "https://vector.im/_matrix/identity/api/v1/pubkey/ephemeral/isvalid",
        "public_key": "unYLHHHx_-kYDh9RLh5RvfcTrDgWnNtLdgPC3yM"
      }
    ],
    "key_validity_url": "https://vector.im/_matrix/identity/v2/pubkey/isvalid",
    "public_key": "ta8IQ0u1sp44HVpxYi7dFOdS/bfwDjcy4xLFlfY5KOA"
  },
  "state_key": "HgjJXrYyxxxOtdmyiJHyYRTjMMAiFdDrbCPqyCMdgCSyGMvxsyztxNQHBXMcUOnLjUOdhCMzSzwYEowxPqIYGYcOnXzNMvAlyOKOmnWrnfglNfBAeVfmZLBvQRqDGg",
  "event_id": "$161658804355dhuce:amorgan.xyz",
  "origin_server_ts": 1616588043476,
  "unsigned": {
    "age": 6048
  },
  "room_id": "!xxx:amorgan.xyz"
}

Have recorded on matrix-org/synapse#9677.

[mscbot]

🔔 This is now entering its final comment period, as per the review above. 🔔

[mscbot]

The final comment period, with a disposition to merge, as per the review above, is now complete.

[turt2live]

Merged 🎉

[richvdh]

For links: this was a follow-up to MSC2140, which introduced (most of) the v2 API.