-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC2753: Peeking via sync (take 2) #2753
Open
ara4n
wants to merge
21
commits into
old_master
Choose a base branch
from
matthew/msc2753
base: old_master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Aug 29, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 52d8d77 - Browse repository at this point
Copy the full SHA 52d8d77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f88343 - Browse repository at this point
Copy the full SHA 2f88343View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4aba8c8 - Browse repository at this point
Copy the full SHA 4aba8c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 752d569 - Browse repository at this point
Copy the full SHA 752d569View commit details
Commits on Aug 31, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 74cc1c3 - Browse repository at this point
Copy the full SHA 74cc1c3View commit details -
spell out that joins should automatically cancel peeks, and that clie…
…nts should tidy up stale peeks
Configuration menu - View commit details
-
Copy full SHA for c4c4b35 - Browse repository at this point
Copy the full SHA c4c4b35View commit details
Commits on Sep 4, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4fba927 - Browse repository at this point
Copy the full SHA 4fba927View commit details
Commits on Sep 8, 2020
-
spell out that we should flash unpeeks in leave to let the client kno…
…w they've vanished
Configuration menu - View commit details
-
Copy full SHA for a070935 - Browse repository at this point
Copy the full SHA a070935View commit details
Commits on Oct 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for acec300 - Browse repository at this point
Copy the full SHA acec300View commit details -
Configuration menu - View commit details
-
Copy full SHA for a255140 - Browse repository at this point
Copy the full SHA a255140View commit details -
Configuration menu - View commit details
-
Copy full SHA for 558f66f - Browse repository at this point
Copy the full SHA 558f66fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4dea820 - Browse repository at this point
Copy the full SHA 4dea820View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b08c09 - Browse repository at this point
Copy the full SHA 8b08c09View commit details
Commits on Oct 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b2cb3f2 - Browse repository at this point
Copy the full SHA b2cb3f2View commit details
Commits on Nov 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a80364d - Browse repository at this point
Copy the full SHA a80364dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 90eba26 - Browse repository at this point
Copy the full SHA 90eba26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b629ba - Browse repository at this point
Copy the full SHA 3b629baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 405c05d - Browse repository at this point
Copy the full SHA 405c05dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12740e5 - Browse repository at this point
Copy the full SHA 12740e5View commit details
Commits on Nov 17, 2020
-
Matthew wants us to drop the `_room` suffix. I worry that this is somewhat confusing (it's not obvious to the casual observer what it is that we are peeking), and risks a lot of confusion in the future when we find something else to peek, but he seems to feel strongly.
Configuration menu - View commit details
-
Copy full SHA for c757849 - Browse repository at this point
Copy the full SHA c757849View commit details
Commits on Nov 26, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 50537aa - Browse repository at this point
Copy the full SHA 50537aaView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.