Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC3038: Typed typing notifications #3038

Open
wants to merge 1 commit into
base: old_master
Choose a base branch
from

Conversation

turt2live
Copy link
Member

@turt2live turt2live changed the title Typed typing notifications [MSC3038] Typed typing notifications Mar 2, 2021
@turt2live turt2live added client-server Client-Server API feature Suggestion for a significant extension which needs considerable consideration proposal A matrix spec change proposal proposal-in-review labels Mar 2, 2021
6. Other users now see them as typing a text message again
7. Finally, the user sends `{"typing": false}` to clear their typing status for other users.

## Potential issues
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something that is unclear is how we'd represent edits. Ideally we don't include metadata about which message is being edited (for privacy reasons), but we could include the remainder of the relationship?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also applies to threads

```

The `event` is a stripped-down version of a real event, indicating the `type` and relevant parts of
the `content` to be included. This does technically allow a client to also send partial events such
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this interact with MSC1767 ooi? I think it still is sane?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, I think it'd probably just send a bunch of empty objects (ie: content: {"m.text": {}, "m.image": {}})

Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this broadly makes sense.

from the room for doing this. Servers could also use pattern-detecting behaviour if appropriate for their
deployment to determine if a user is abusing typing notifications (for example, a user is unlikely to be
typing a message for 4 solid hours).

Copy link
Member

@dbkr dbkr May 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also makes it a bit easier for an attacker to send large amounts of data in the typing event and generally waste resources. One could argue there are other ways to do that though. That said, I'm inclined to say that making it a namespaced string rather than a partial event body would solve all the use cases with fewer footguns?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's not as future proof (we'd have to remember to add m.edit, m.voice, m.file, etc with each MSC), but it would probably be more sane data-wise.

Could also be argued that servers should be size-limiting EDUs like this.

@turt2live turt2live changed the title [MSC3038] Typed typing notifications MSC3038: Typed typing notifications Jun 7, 2021
@turt2live turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 8, 2021
such as potentially streaming uploads or other lengthy message sending stats (as this approach could
send progress information too).

## Alternatives
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't #2477 also be counted as a potential alternative?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a bit of a stretch for "alternative", sure. I don't think it's fair to count it given we're fundamentally sending a rich typing notification.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue that that MSC could subsume this one and typing notifications entirely, and so could be seen as an alternative, thus the mention. 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2477 defines a way for custom EDUs to be sent, not replace the existing EDUs system. If we push typing notifications into that, we're effectively introducing fragmentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API feature Suggestion for a significant extension which needs considerable consideration kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants