MSC3245: Voice messages (using extensible events) #3245
Conversation
turt2live
changed the title
turt2live
added
client-server
|
This hasn't really received much negative press, and has been working well in Element Web for a while. The mobile apps appear to be handling the Opus/Ogg bits well enough. All 3 test platforms ran into issues with encoding Opus, but all appear to have jumped that hurdle with relative ease. As such, a plea for final comments: @mscbot fcp merge |
|
This FCP proposal has been cancelled by #3245 (comment). Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people: Concerns:
Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for information about what commands tagged team members can give me. |
mscbot
added
disposition-merge
proposed-final-comment-period
Co-authored-by: David Baker <dbkr@users.noreply.github.com>
proposals/3245-voice-messages.md
Outdated
| The `m.voice` identifier could probably conflict, as `m.audio` could conflict as well. We may be interested in | ||
| discussing `m.message.voice` or similar instead, though likely at MSC1767 rather than this proposal. | ||
|
|
||
| This also annotates events with an empty object and potentially a lot of extra information. This is considered | ||
| to be an issue for MSC1767 to consider rather than this MSC, as this MSC is simply saying to create audio events | ||
| with some sort of voice message type. |
There was a problem hiding this comment.
it seems like we need to resolve these issues in MSC1767 before we can sensibly complete this MSC.
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
|
@mscbot concern Too much of a reliance on extensible events to move forward |
mscbot
added
the
unresolved-concerns
Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>
|
This is blocked and unable to make forward progress, so pulling it out of the SCT's "look at this now" queue: @mscbot fcp cancel |
mscbot
added
proposal-in-review
and removed
proposed-final-comment-period
| Voice messages are a useful way to quickly send a message to someone without having to use the more | ||
| awkward keyboard. Typically short in length, voice messages can be sent as annotated audio files | ||
| to recipients. |
There was a problem hiding this comment.
This MSC doesn't motivate why voice messages should exist as a separate concept in addition to the more generic audio messages. I had to go over to MSC2516 to find some (potential) reasons. Could that be added?
This comment was marked as duplicate.
This comment was marked as duplicate.
| trusted, and the user's voice is not uploaded plainly to the media repo. Typically, this will be DMs or other | ||
| forms of private chats in most clients. | ||
|
|
||
| ## Unstable prefix |
There was a problem hiding this comment.
@jonnyandrew says:
@turt2live we're planning to implement this MSC in Element X but we're conscious that an older version (v1) has already been implemented in the Element Classic apps. Should we prefer to implement v2 in Element X in order to help progress the MSC? Or will it be okay to stick with v1 so that EC and EX can talk to each other? cc @nimau
There was a problem hiding this comment.
I don't recall which version is already deployed out in the wild, but would recommend using the one that other clients use. If it turns out that no one implements the v2 stuff (like in the case with Polls), we can fix this MSC.
Rendered
Note: due to the size of the feature on the UI side, this has a number of implementation links. Some may have been missed so please review the core sectional links as needed. Note also that only references relevant to this MSC are included.
Element Web/Desktop implementation:
Element Android implementation (incomplete):
Element iOS implementation (incomplete):
FCP: #3245 (comment)