Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC3279: Expose enable_set_displayname in capabilities response #3279

Closed
wants to merge 4 commits into from
Closed

MSC3279: Expose enable_set_displayname in capabilities response #3279

wants to merge 4 commits into from

Conversation

JonasKress
Copy link
Contributor

@JonasKress JonasKress added proposal A matrix spec change proposal client-server Client-Server API labels Jul 13, 2021
@anoadragon453 anoadragon453 self-requested a review July 13, 2021 10:23
KitsuneRal
KitsuneRal requested changes Jul 13, 2021
View reviewed changes
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very straightforward and uncontroversial. As a client author, I definitely see a value from exposing it (even though I don't sit on homeservers with enable_set_displayname: false). A few suggestions below.

proposals/3278-enable_set_displayname-capabilities.md Outdated Show resolved Hide resolved
proposals/3278-enable_set_displayname-capabilities.md Outdated Show resolved Hide resolved
proposals/3278-enable_set_displayname-capabilities.md Outdated Show resolved Hide resolved
@dklimpel dklimpel mentioned this pull request Jul 13, 2021
Closed
@dklimpel
Copy link
Contributor

Relates to: #1862 (presence) and #3244 (rooms)

JonasKress and others added 2 commits July 13, 2021 14:24
@JonasKress @KitsuneRal
Apply suggestions from code review
0fd7c94 
Co-authored-by: Alexey Rusakov <Kitsune-Ral@users.sf.net>
@JonasKress @KitsuneRal
Apply suggestions from code review
c711706 
Co-authored-by: Alexey Rusakov <Kitsune-Ral@users.sf.net>
@turt2live turt2live changed the title MSC3278: Expose enable_set_displayname in capabilities response MSC3279: Expose enable_set_displayname in capabilities response Jul 13, 2021
@turt2live turt2live added kind:feature MSC for not-core and not-maintenance stuff proposal-in-review labels Jul 13, 2021
@JonasKress JonasKress closed this Jul 13, 2021
@JonasKress JonasKress deleted the JonasKress/msc3278 branch July 13, 2021 17:22
@JonasKress
Copy link
Contributor Author

New pull request as branch was rename

@turt2live turt2live added obsolete A proposal which has been overtaken by other proposals and removed proposal-in-review labels Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dklimpel dklimpel dklimpel left review comments

@turt2live turt2live turt2live left review comments

@KitsuneRal KitsuneRal KitsuneRal requested changes

@anoadragon453 anoadragon453 Awaiting requested review from anoadragon453

Assignees
No one assigned
Labels
client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff obsolete A proposal which has been overtaken by other proposals proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JonasKress @dklimpel @turt2live @KitsuneRal