-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC3291: Muting in VoIP calls #3291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
SimonBrandner
changed the title
MSC: Muting in VoIP calls
MSC3291: Muting in VoIP calls
Jul 22, 2021
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
ara4n
reviewed
Jul 22, 2021
ara4n
reviewed
Jul 22, 2021
turt2live
added
kind:core
MSC which is critical to the protocol's success
proposal
A matrix spec change proposal
proposal-in-review
voip
needs-implementation
This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP.
labels
Jul 23, 2021
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally sensible so far!
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
SimonBrandner
commented
Jul 27, 2021
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
This was referenced Jul 27, 2021
dbkr
removed
the
needs-implementation
This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP.
label
Aug 2, 2021
@mscbot resolve review comments up to June 6, 2023 |
mscbot
removed
the
unresolved-concerns
This proposal has at least one outstanding concern
label
Jul 4, 2023
richvdh
reviewed
Jul 4, 2023
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
🔔 This is now entering its final comment period, as per the review above. 🔔 |
mscbot
added
final-comment-period
This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days.
and removed
proposed-final-comment-period
Currently awaiting signoff of a majority of team members in order to enter the final comment period.
labels
Jul 11, 2023
The final comment period, with a disposition to merge, as per the review above, is now complete. |
mscbot
added
finished-final-comment-period
and removed
disposition-merge
final-comment-period
This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days.
labels
Jul 16, 2023
turt2live
added
spec-pr-missing
Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec
and removed
finished-final-comment-period
labels
Jul 16, 2023
turt2live
pushed a commit
that referenced
this pull request
Aug 4, 2023
* MSC: Muting in VoIP calls Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Update MSC number Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Missing : Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Fix MSC number in prefix Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Fix unstable prefix table Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Reword pottential issues Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Add an Alternatives section Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Remove trailing comma Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Fix a typo Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Fix missing word Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Link to MSC for holding Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Update unstable prefixes Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Simplify things Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Be explicit about deps Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Be clearer about how things work Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Update proposals/3291-muting.md Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * `disabled` -> `enabled` Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Fix client mention Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Improve explaination Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Be more precise Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Fix negation Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Don't refer to something that doesn't exist Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> --------- Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
23 tasks
Spec PR: matrix-org/matrix-spec#1755 |
turt2live
added
spec-pr-in-review
A proposal which has been PR'd against the spec and is in review
and removed
spec-pr-missing
Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec
labels
Mar 19, 2024
Merged! 🎉 |
richvdh
added
merged
A proposal whose PR has merged into the spec!
and removed
spec-pr-in-review
A proposal which has been PR'd against the spec and is in review
labels
Mar 26, 2024
This was referenced Apr 19, 2024
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: #3077
Rendered
js-sdk
implementationreact-sdk
implementationThanks to @dbkr for help with this!
FCP tickyboxes