Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC3571: Relation aggregation pagination #3571

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bwindels
Copy link
Contributor

@bwindels bwindels commented Dec 16, 2021

@bwindels bwindels changed the title MSCXXXX: Relation aggregation pagination MSC3571: Relation aggregation pagination Dec 16, 2021
@@ -0,0 +1,129 @@
# MSC3571: Aggregation pagination

MSC 2675 introduced aggregating relations on the server. The goal of bundled aggregations is to be more bandwidth efficient. For relations that aggregate to an array with many entries, we might actually end up sending too much data still when bundling.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We write MSC numbers without a space between the "MSC" and the number. Also, please wrap your lines.

proposals/3571-aggregation-pagination.md Show resolved Hide resolved
@uhoreg uhoreg added client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal proposal-in-review labels Dec 16, 2021

This MSC proposes a pagination mechanism for aggregations so we don't need to bundle all entries for array aggregations.

Both MSC 2677 and MSC MSC 3267 would benefit from the pagination mechanism, hence proposing it in a separate MSC rather than including it in either of those.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSC2677 ended up not including an aggregation.

Comment on lines +68 to +69
The `/aggregations` API lets you iterate over aggregations for the relations
of a given event.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The /aggregation endpoint ended up not landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants