Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static location sharing tweaks #3623

Merged
merged 4 commits into from
Jan 12, 2022
Merged

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Jan 5, 2022

Added m.asset tracked asset subtype and zoom levels.

Preview: https://pr3623--matrix-org-previews.netlify.app

@stefanceriu stefanceriu requested a review from ara4n January 5, 2022 12:54
proposals/3488-location.md Outdated Show resolved Hide resolved
@ara4n
Copy link
Member

ara4n commented Jan 5, 2022

lgtm other than needing a more formal introduction of the m.asset mixin

proposals/3488-location.md Outdated Show resolved Hide resolved
proposals/3488-location.md Outdated Show resolved Hide resolved
Copy link
Member

@ara4n ara4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm also!

Co-authored-by: Matthew Hodgson <matthew@matrix.org>
@stefanceriu stefanceriu merged commit 5c8e2ba into matthew/location Jan 12, 2022
@stefanceriu stefanceriu deleted the stefan/location branch January 12, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants