Add contains_url filter option and /messages filter #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Supercedes https://docs.google.com/document/d/1J-Bd9QM_h6pH3xLidsIPsyNRQZGc3VfeKdy6O8bQLHI/edit, presumably? |
|
yup |
richvdh
requested changes
Sep 30, 2016
| @@ -28,4 +28,8 @@ properties: | |||
| items: | |||
| type: string | |||
| type: array | |||
| contains_url: | |||
| type: boolean | |||
| description: If specified will filter events based on if they have a url key in their | |||
There was a problem hiding this comment.
"If true, includes only events with a url key in their content. If false, excludes those events"
maybe?
| type: string | ||
| name: filter | ||
| description: |- | ||
| A url encoded JSON RoomEventFilter to filter returned events with. |
There was a problem hiding this comment.
well, of course it's url-encoded. it's a query-param. I don't think there is a need to specify this. Unless you mean it's double-encoded?
I would just say "A JSON-encoded RoomEventFilter to filter returned events with."
But the main thing it needs is an example.
| @@ -35,6 +35,10 @@ | |||
| - Add top-level ``account_data`` key to the responses to ``GET /sync`` and | |||
| ``GET /initialSync`` | |||
| (`#380 <https://github.com/matrix-org/matrix-doc/pull/380>`_). | |||
| - Add ``contains_url`` to ``RoomEventFilter``. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not really sure the best way of spec'ing the filter param on
/messages, suggestions welcome.