Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC4001: Return start of room state at context endpoint #4001

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

MSC4001: Return start of room state at context endpoint #4001

wants to merge 3 commits into from

Conversation

BramvdnHeuvel
Copy link

No description provided.

@BramvdnHeuvel BramvdnHeuvel changed the title MSCxxxx Return start of room state at context endpoint MSC4001 Return start of room state at context endpoint Apr 21, 2023
@BramvdnHeuvel BramvdnHeuvel changed the title MSC4001 Return start of room state at context endpoint MSC4001: Return start of room state at context endpoint Apr 21, 2023
@BramvdnHeuvel BramvdnHeuvel marked this pull request as ready for review April 21, 2023 15:58
@uhoreg uhoreg added proposal A matrix spec change proposal client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Apr 21, 2023
uhoreg
uhoreg reviewed Apr 21, 2023
View reviewed changes
proposals/4001-context-state-at-start.md Outdated

## Proposal

For the same reason that this behaviour was altered for the `GET /_matrix/client/v3/sync` endpoint, the endpoint `GET /_matrix/client/v3/rooms/{roomId}/context/{eventId}` should use the `state` field in its 200 response to return the room state at the **first** event returned.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under the assumption that this isn't a spec bug, this would be be an incompatible change and could break clients that rely on the current behaviour. This could be solved by adding a query parameter to indicate that the server should use this behaviour. Alternatively, the version number on this endpoint could be bumped. Or you could show that clients don't rely on the current behaviour.

@anoadragon453 anoadragon453 mentioned this pull request May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uhoreg uhoreg uhoreg left review comments

Assignees
No one assigned
Labels
client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BramvdnHeuvel @uhoreg