Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC4040: Update SRV service name to IANA registration #4040
MSC4040: Update SRV service name to IANA registration #4040
Changes from all commits
5dd5cc8
4622477
bbfb967
d68651a
3b75971
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am somewhat 👎 on this (MSC4040) and would still prefer that we drop SRV support.
I continue to feel that the current SRV support serves almost entirely to confuse people; a significant portion of the traffic in
#synapse:matrix.org
continues to be people trying and failing to set up federation because they are using SRV records with the wrong certificates.Erik raises good points at #3922 (comment) but the fact remains that correctly configuring a deployment using SRV records instead of
.well-known
is so damn hard that virtually nobody does it. Evenmatrix.org
uses a .well-known file, and if anyone could benefit from avoiding the.well-known
, it'smatrix.org
.Adding even more complexity to it seems like, frankly, a retrograde step. If we deprecated SRV records now and then in future it turns out that we can't live without them, then re-introducing them based on
_matrix-fed._tcp
isn't going to be any harder than it is now.(also: it's not entirely obvious to me that SRV records are the future: SVCB records look like they might replace them for our purposes).
Still, if everyone else is in favour, I'll not stand in the way.
-0.5 from me on the Apache Voting Scale