Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrospectively re-update MSC2403 to clarify that invite->knock is *not* legal. #4091

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Retrospectively re-update MSC2403 to clarify that invite->knock is *not* legal. #4091

merged 1 commit into from
Feb 21, 2024

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Jan 23, 2024

@turt2live turt2live requested a review from a team January 23, 2024 19:51
@richvdh richvdh changed the title Clarify that invite->knock is not legal. Retrospectively re-update MSC2403 to clarify that invite->knock is *not* legal. Jan 25, 2024
@richvdh
Copy link
Member

richvdh commented Jan 25, 2024

For links: this updates #2403.

richvdh
richvdh approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but in the spirit of us having royally fscked this up in the past, maybe others would like to weigh in and double-check that this is a sensible thing to do

@richvdh
Copy link
Member

richvdh commented Jan 25, 2024

/cc @deepbluev7 @Gnuxie as people who have strong opinions on how this has been handled.

@richvdh richvdh mentioned this pull request Jan 25, 2024
Merged
dbkr
dbkr approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, thanks for wading through this and getting it sorted!

@turt2live
Copy link
Member

I'm assuming 2 approving reviews is plenty

@turt2live turt2live merged commit 94de0bd into main Feb 21, 2024
1 check passed
@turt2live turt2live deleted the kegan/knock-invite-transition branch February 21, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kegsay @richvdh @turt2live @dbkr