MSC4154: Request max body size #4154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
added
proposal
turt2live
commented
Jun 11, 2024
There was a problem hiding this comment.
Implementation requirements:
- Reverse proxy configuration demonstrating Matrix standard error response.
- nginx
- apache2
- haproxy
- traefik
- caddy
vojta001
reviewed
Jun 15, 2024
Comment on lines
+17
to
+20
| API endpoints. If a request exceeds this limit, the client SHOULD be presented with a `413 M_TOO_LARGE` | ||
| error. The `M_TOO_LARGE` error code [already exists](https://spec.matrix.org/v1.10/client-server-api/#other-error-codes). | ||
|
|
||
| Servers MAY raise this limit to higher than 1 MB, but SHOULD NOT lower it below 1 MB. |
There was a problem hiding this comment.
I find this wording a little unclear: Is it that servers should send M_TOO_LARGE for requests larger than 1 MB? Or that servers should send M_TOO_LARGE for requests larger than the servers' limit, which may be above 1 MB, but should not be under it?
I personally prefer the second interpretation, but whichever is the intended one, I think the wording should make it clear.
DISCLAIMER: I am just an ordinary matrix user with zero standards writing experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
In line with matrix-org/matrix-spec#1700, the following disclosure applies:
I am Director of Standards Development at The Matrix.org Foundation C.I.C., Matrix Spec Core Team (SCT) member, employed by Element, and operate the t2bot.io service. This proposal is written and published as Director of Standards Development to assist in furthering the spec.