Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC4189: Allowing guests to access uploaded media #4189

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Sep 5, 2024

Rendered

In line with matrix-org/matrix-spec#1700, the following disclosure applies:

I am Director of Standards Development at The Matrix.org Foundation C.I.C., Matrix Spec Core Team (SCT) member, employed by Element, and operate the t2bot.io service. This proposal is written and published as a Trust & Safety team member allocated in full to the Foundation.

FCP tickyboxes

@turt2live turt2live changed the title MSC: Allowing guests to access uploaded media MSC4189: Allowing guests to access uploaded media Sep 5, 2024
@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Sep 5, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what level of implementation we require for this, but element-hq/synapse#17675 exists.

@turt2live turt2live removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Sep 5, 2024
@turt2live
Copy link
Member Author

turt2live commented Sep 5, 2024

@mscbot fcp merge

edit: this MSC appears to be trivial enough to move to the next stage of the process.

@mscbot
Copy link
Collaborator

mscbot commented Sep 5, 2024

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Sep 5, 2024
@@ -0,0 +1,53 @@
# MSC4189: Allowing guests to access uploaded media
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a perfectly resonable proposal to me. Its clearly fixing a oversight in MSC3916 since being able to access media seems pretty essential for guest accounts. Since even if its limited only to avatars by a server its still important to be able to render avatars.

The argument for why this proposal seems sane writes it self as far as i can tell.

@mscbot
Copy link
Collaborator

mscbot commented Sep 23, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Sep 23, 2024
@mscbot
Copy link
Collaborator

mscbot commented Sep 28, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Sep 28, 2024
@anoadragon453 anoadragon453 merged commit 4c0ec1e into main Sep 30, 2024
1 check passed
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Sep 30, 2024
turt2live added a commit to matrix-org/matrix-spec that referenced this pull request Sep 30, 2024
@turt2live
Copy link
Member Author

Spec PR: matrix-org/matrix-spec#1959

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Sep 30, 2024
@turt2live turt2live self-assigned this Sep 30, 2024
turt2live added a commit to matrix-org/matrix-spec that referenced this pull request Sep 30, 2024
@turt2live
Copy link
Member Author

Merged 🎉

@turt2live turt2live deleted the travis/msc/guest-access-media branch September 30, 2024 17:36
@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Sep 30, 2024
@zecakeh zecakeh mentioned this pull request Oct 5, 2024
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
Status: Done to some definition
Development

Successfully merging this pull request may close these issues.

4 participants