-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC4189: Allowing guests to access uploaded media #4189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what level of implementation we require for this, but element-hq/synapse#17675 exists.
@mscbot fcp merge edit: this MSC appears to be trivial enough to move to the next stage of the process. |
Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people: Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for information about what commands tagged team members can give me. |
@@ -0,0 +1,53 @@ | |||
# MSC4189: Allowing guests to access uploaded media |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a perfectly resonable proposal to me. Its clearly fixing a oversight in MSC3916 since being able to access media seems pretty essential for guest accounts. Since even if its limited only to avatars by a server its still important to be able to render avatars.
The argument for why this proposal seems sane writes it self as far as i can tell.
🔔 This is now entering its final comment period, as per the review above. 🔔 |
The final comment period, with a disposition to merge, as per the review above, is now complete. |
Spec PR: matrix-org/matrix-spec#1959 |
Merged 🎉 |
Rendered
In line with matrix-org/matrix-spec#1700, the following disclosure applies:
I am Director of Standards Development at The Matrix.org Foundation C.I.C., Matrix Spec Core Team (SCT) member, employed by Element, and operate the t2bot.io service. This proposal is written and published as a Trust & Safety team member allocated in full to the Foundation.
FCP tickyboxes