Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Specify Content-Disposition and Content-Type semantics on /download and /thumbnail #1758

Closed
wants to merge 1 commit into from

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Mar 19, 2024

Likely better with #1756

See matrix-org/matrix-spec-proposals#2702
See matrix-org/matrix-spec-proposals#2701

TODO:

Preview: https://pr1758--matrix-spec-previews.netlify.app

@tulir
Copy link
Member

tulir commented May 29, 2024

The conduwuit devs implemented content type sniffing recently as they weren't sure if it's safe to trust user input there (and weren't aware of MSC2701 at the time). I think the spec should have some words explaining why it's safe, and particularly the interaction between content-type and content-disposition (disposition must be derived from the same type that is served, using different values opens security issues)

@turt2live
Copy link
Member Author

Closing in favour of #1935

@turt2live turt2live closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants