Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC4170: 403 error responses for profile APIs #1867

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Jun 12, 2024

Spec for matrix-org/matrix-spec-proposals#4170.

Pull Request Checklist

Preview: https://pr1867--matrix-spec-previews.netlify.app

Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@Johennes Johennes marked this pull request as ready for review June 12, 2024 14:07
@Johennes Johennes requested a review from a team as a code owner June 12, 2024 14:07
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but will await opinions from other SCT members on https://github.com/matrix-org/matrix-spec/pull/1867/files#r1636536644

data/api/server-server/query.yaml Outdated Show resolved Hide resolved
@Johennes Johennes changed the title Add missing 403 responses on profile endpoints MSC4170: 403 error responses for profile APIs Oct 7, 2024
@Johennes Johennes marked this pull request as ready for review October 7, 2024 08:01
@Johennes
Copy link
Contributor Author

Johennes commented Oct 7, 2024

I've optimistically used x-addedInMatrixVersion: "1.12" but this doesn't block the 1.12 release in any way. If the release happens before this PR lands, I'll bump the versions to 1.13.

@Johennes Johennes requested a review from richvdh October 7, 2024 08:02
richvdh pushed a commit to matrix-org/matrix-spec-proposals that referenced this pull request Oct 7, 2024
Relates to matrix-org/matrix-spec#1867

Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. THanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants