Fixes for reading room state #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robintown
reviewed
Jan 27, 2025
… events) reads from the state or the timeline
Co-authored-by: Robin <robin@robin.town>
toger5
force-pushed
the
toger5/fix-reading-room-state-events-for-client-widget-api
branch
from
165359e to
de97f9e
Compare
|
I re-based on the formatting changes. |
robintown
approved these changes
Jan 27, 2025
|
toger5
deleted the
toger5/fix-reading-room-state-events-for-client-widget-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127
This fixes an issue where when a widget read the room state using read_events.
Previously this was using the current room state to populate the returned events. Not it uses the timeline.
For widgets that do not use the update_state action this is how they expected to receive events. They will not work anymore.
This change makes read_state return the current state again.