Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MSC3869: Read event relations with the Widget API #72

Merged
merged 8 commits into from
Aug 30, 2022
Merged

Implement MSC3869: Read event relations with the Widget API #72

merged 8 commits into from
Aug 30, 2022

Conversation

dhenneke
Copy link
Contributor

@dhenneke dhenneke commented Aug 22, 2022 •
edited
Loading

See matrix-org/matrix-spec-proposals#3869 for more details.

This also sets up jest and adds a GitHub workflow to lint the code and run tests.

@dhenneke
Setup jest and create a first test
88f3dd7 
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
@dhenneke
Setup the build pipeline
e42883e 
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
@dhenneke
Add an action to read relations according to MSC3869
4fb032a 
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
This was referenced Aug 22, 2022
Merged
Open
@dhenneke dhenneke marked this pull request as ready for review August 23, 2022 09:48
@dhenneke dhenneke requested a review from a team as a code owner August 23, 2022 09:48
@dhenneke dhenneke requested review from andybalaam, turt2live and kerryarchibald and removed request for a team August 23, 2022 09:48
turt2live
turt2live reviewed Aug 24, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this looks pretty good to me, though I haven't reviewed the MSC as much as I probably should 😇

Passing to voip team to finalize review.

src/ClientWidgetApi.ts Outdated Show resolved Hide resolved
test/ClientWidgetApi-test.ts Outdated Show resolved Hide resolved
src/interfaces/ReadRelationsAction.ts Outdated Show resolved Hide resolved
test/ClientWidgetApi-test.ts Outdated Show resolved Hide resolved
test/WidgetApi-test.ts Outdated Show resolved Hide resolved
test/setupTests.js Outdated Show resolved Hide resolved
test/setupTests.js Outdated Show resolved Hide resolved
src/WidgetApi.ts Show resolved Hide resolved
@turt2live turt2live requested review from a team and removed request for andybalaam and kerryarchibald August 24, 2022 03:17
@dhenneke
Remove empty setupTests file
2b448a2 
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
@dhenneke
Update copyright headers
ebda0d9 
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
@dhenneke
Announce the api version of the action
fdf5421 
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
robintown
robintown reviewed Aug 26, 2022
View reviewed changes
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I just have a few minor comments

src/driver/WidgetDriver.ts Outdated Show resolved Hide resolved
test/ClientWidgetApi-test.ts Outdated Show resolved Hide resolved
test/ClientWidgetApi-test.ts Outdated Show resolved Hide resolved
test/WidgetApi-test.ts Outdated Show resolved Hide resolved
test/WidgetApi-test.ts Outdated Show resolved Hide resolved
test/WidgetApi-test.ts Outdated Show resolved Hide resolved
test/WidgetApi-test.ts Outdated Show resolved Hide resolved
@dhenneke
Extract the return type into an interface
b5db4d7 
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
@dhenneke
Prefer enums over strings in the tests
cd1a950 
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
@robintown robintown merged commit 839180d into matrix-org:master Aug 30, 2022
@dhenneke dhenneke deleted the nic/feat/read-relations branch August 31, 2022 11:20
@dhenneke dhenneke mentioned this pull request Sep 7, 2022
Merged
@Fox32 Fox32 mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live left review comments

@robintown robintown robintown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhenneke @turt2live @robintown