Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MSC3869: Read event relations with the Widget API #72

Merged
merged 8 commits into from
Aug 30, 2022

Conversation

dhenneke
Copy link
Contributor

@dhenneke dhenneke commented Aug 22, 2022

See matrix-org/matrix-spec-proposals#3869 for more details.

This also sets up jest and adds a GitHub workflow to lint the code and run tests.

Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this looks pretty good to me, though I haven't reviewed the MSC as much as I probably should 😇

Passing to voip team to finalize review.

src/ClientWidgetApi.ts Outdated Show resolved Hide resolved
test/ClientWidgetApi-test.ts Outdated Show resolved Hide resolved
src/interfaces/ReadRelationsAction.ts Outdated Show resolved Hide resolved
test/ClientWidgetApi-test.ts Outdated Show resolved Hide resolved
test/WidgetApi-test.ts Outdated Show resolved Hide resolved
test/setupTests.js Outdated Show resolved Hide resolved
test/setupTests.js Outdated Show resolved Hide resolved
src/WidgetApi.ts Show resolved Hide resolved
@turt2live turt2live requested review from a team and removed request for andybalaam and kerryarchibald August 24, 2022 03:17
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I just have a few minor comments

src/driver/WidgetDriver.ts Outdated Show resolved Hide resolved
test/ClientWidgetApi-test.ts Outdated Show resolved Hide resolved
test/ClientWidgetApi-test.ts Outdated Show resolved Hide resolved
test/WidgetApi-test.ts Outdated Show resolved Hide resolved
test/WidgetApi-test.ts Outdated Show resolved Hide resolved
test/WidgetApi-test.ts Outdated Show resolved Hide resolved
test/WidgetApi-test.ts Outdated Show resolved Hide resolved
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
@robintown robintown merged commit 839180d into matrix-org:master Aug 30, 2022
@dhenneke dhenneke deleted the nic/feat/read-relations branch August 31, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants