Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nonfunctional menu button in narrow view #1696

Conversation

gitabhisingh
Copy link

@gitabhisingh gitabhisingh commented Mar 29, 2023

There were some URL encoded chars where href was throwing errors for invalid URL, which need to be replaced with actual special characters.

  1. fixed encoded URL and ID special characters from FAQ page
  2. removed a warning for className in Footer page.

Note:

  • I was not able to find FAQ file on zolo repo, it's in md file there. so I created a PR against master branch
  • some indentation changes might have occurred due to my Prettier extension.

Closes #1508

Screenshot after changes and dev testing:

Screenshot 2023-03-28 at 9 39 51 PM

@gitabhisingh gitabhisingh changed the title gitabhisingh | Fixes Nonfunctional menu button in narrow view #1508 gitabhisingh | Fixes Nonfunctional menu button in narrow view Mar 29, 2023
@gitabhisingh gitabhisingh changed the title gitabhisingh | Fixes Nonfunctional menu button in narrow view Fixes Nonfunctional menu button in narrow view Mar 29, 2023
@richvdh
Copy link
Member

richvdh commented Apr 3, 2023

@thibaultamartin my understanding is that we are not currently accepting PRs against master - is that correct?

@richvdh richvdh requested a review from thibaultamartin April 3, 2023 20:08
@richvdh richvdh changed the title Fixes Nonfunctional menu button in narrow view Fix nonfunctional menu button in narrow view Apr 3, 2023
@gitabhisingh
Copy link
Author

@richvdh I am not able to find these HTML changes in zola repo, I see they got migrated to md file. If that's intentional then we can close this issue & PR then.

@thibaultamartin
Copy link
Contributor

Hi all, just getting back from holidays. Indeed, we're currently working on a complete rewrite of the matrix.org website, and we don't accept changes against the master branch.

I will update the README accordingly, and set-up a tag system so it's more obvious where we accept help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nonfunctional menu button in narrow view
3 participants