Add an API to filter user directory searches by MXID or display name. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
reviewed
Feb 13, 2020
|
I think I've hit all the comments here, please take another look! |
turt2live
approved these changes
Feb 13, 2020
|
|
||
| # Check whether the user ID or display name matches any of the banned | ||
| # patterns. | ||
| return self.is_user_banned(user_profile["user_id"]) or self.is_user_banned(user_profile["display_name"]) |
There was a problem hiding this comment.
I meant to keep the user ID as its own arg, but this is fine too
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would depend on matrix-org/synapse#6888 to be functional, it is likely worth taking a quick look at the API design in there first.
As noted in the synapse PR, I don't love the name of the chosen API method. Any suggestions would be appreciated!
I'm unsure if it makes sense to apply the same filtering (
is_user_banned) over both the MXID and the display name, but it seemed like the simplest change to start with. What are your thoughts on this?Related to matrix-org/synapse#5648.