Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where bootstrap ack was handled incorrectly #31

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Fix bug where bootstrap ack was handled incorrectly #31

merged 1 commit into from
Feb 23, 2022

Conversation

devonh
Copy link
Collaborator

@devonh devonh commented Feb 22, 2022

No description provided.

@devonh
Copy link
Collaborator Author

devonh commented Feb 22, 2022

Maybe it would be more correct to compare against asc.Target instead of asc.Origin?
Either way, it should be the same value.

@neilalexander
Copy link
Contributor

Origin should be fine — good catch!

@neilalexander neilalexander merged commit 0f0afd1 into main Feb 23, 2022
@neilalexander neilalexander deleted the bootstrap-loop branch February 23, 2022 10:44
devonh added a commit that referenced this pull request Feb 26, 2022
@devonh
Fix bug where bootstrap ack was handled incorrectly (#31)
02a66ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devonh @neilalexander