Skip to content
This repository has been archived by the owner on Nov 25, 2022. It is now read-only.

Install the proper requirements for pysaml2 in the trial test runners. #110

Merged
merged 2 commits into from
Nov 27, 2020

Conversation

clokep
Copy link
Member

@clokep clokep commented Nov 24, 2020

This installs xmlsec1 onto the Synapse trial test runners. This is required for pysaml2, so we need it for matrix-org/synapse#8800.

I wasn't sure if it made more sense to make a shell script in the Synapse repo and call that (like we do for old deps), but this seemed more tamper-proof.

Note that this gets installed for the old-deps build in matrix-org/synapse#8800.

I also wondered if there's a way to re-use steps or something for buildkite, but didn't see anything obvious.

@clokep clokep requested a review from a team November 24, 2020 14:01
@richvdh
Copy link
Member

richvdh commented Nov 24, 2020

I also wondered if there's a way to re-use steps or something for buildkite, but didn't see anything obvious.

you can use yaml entities if you want. the element-ios pipeline has examples iirc

@clokep
Copy link
Member Author

clokep commented Nov 24, 2020

I also wondered if there's a way to re-use steps or something for buildkite, but didn't see anything obvious.

you can use yaml entities if you want. the element-ios pipeline has examples iirc

Thanks! I made some changes based on that, not really sure how to test them though.

@richvdh
Copy link
Member

richvdh commented Nov 27, 2020

Thanks! I made some changes based on that, not really sure how to test them though.

for future reference, there are some notes on testing pipelines at https://gitlab.matrix.org/new-vector/internal/-/wikis/BuildKite#testing-a-pipeline-locally.

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richvdh richvdh merged commit 8419b18 into master Nov 27, 2020
@richvdh richvdh deleted the clokep/pysaml2-reqs branch November 27, 2020 13:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants