This repository has been archived by the owner on Nov 25, 2022. It is now read-only.
Enable mypy typechecking & isort checking for Sygnal #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
reivilibre
changed the title
|
@reivilibre Now that we merged the underlying PR is this ready to go? |
|
I think the isort CLI changed, going to check... |
…ility Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
richvdh
reviewed
Jul 14, 2020
|
Sure, I'll look into it! |
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready yet; waiting on matrix-org/sygnal#131.Now also uses
tox.Signed-off-by: Olivier Wilkinson (reivilibre) olivier@librepush.net