Remove unspecified 'success' parameter from requestToken responses

matrix-org · Jun 17, 2020 · fd385c5 · fd385c5
1 parent a005037
commit fd385c5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/302.bugfix b/changelog.d/302.bugfix
@@ -0,0 +1 @@
+Stop sending the unspecified `success` parameter in responses to `/requestToken` requests.
diff --git a/sydent/http/servlets/emailservlet.py b/sydent/http/servlets/emailservlet.py
@@ -66,7 +66,7 @@ def render_POST(self, request):
             sid = self.sydent.validators.email.requestToken(
                 email, clientSecret, sendAttempt, nextLink, ipaddress=ipaddress
             )
-            resp = {'success': True, 'sid': str(sid)}
+            resp = {'sid': str(sid)}
         except EmailAddressException:
             request.setResponseCode(400)
             resp = {'errcode': 'M_INVALID_EMAIL', 'error': 'Invalid email address'}