-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mypy.ini, mypy-zope-plugin #357
Conversation
I see that I have to rebase this once 355 is merged and force push it as there are commits from 355 in here-this is because I based it on a branch that has not been merged, correct? |
hopefully this is good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would also be great if you could make a final commit in here with git commit --signoff
to automatically add in the Signed-off-by: ...
line to the commit message
Signed-off-by: H.Shay <shaysquared@gmail.com>
Looks good to me! So sorry for the pedantry, but one final change to request: could you please split the changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...and a few other comments
Question re: this comment: #357 (comment) |
Signed-off-by: H.Shay <shaysquared@gmail.com>
Let's go with reverting e618512 here |
For small PRs, or ones that haven't been reviewed yet, it's common to use |
Otherwise, consider this 👍 once that revert happens :) |
… change was moved to another PR. This reverts commit e618512.
This PR adds a mypy.ini file, and specifies modules which are missing type support to be ignored. It also adds the mypy-zope plugin, and fixes a mypy error in utils/emailutils per this convo: #355 (comment)
signed off by H-Shay, shaysquared@gmail.com