Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type checking #358

Merged
merged 9 commits into from
Jun 15, 2021
Merged

Improve type checking #358

merged 9 commits into from
Jun 15, 2021

Conversation

H-Shay
Copy link
Contributor

@H-Shay H-Shay commented Jun 10, 2021

This PR fixes some small errors raised by mypy after adding type hints. I tried not to be too invasive and stuck to the (hopefully) simple changes.

signed off by H-Shay shaysquared@gmail.com

Copy link
Contributor

@callahad callahad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! This is great, just a few changes requested

sydent/http/httpcommon.py Outdated Show resolved Hide resolved
sydent/validators/common.py Show resolved Hide resolved
sydent/http/matrixfederationagent.py Outdated Show resolved Hide resolved
sydent/http/matrixfederationagent.py Outdated Show resolved Hide resolved
sydent/http/matrixfederationagent.py Outdated Show resolved Hide resolved
sydent/replication/peer.py Outdated Show resolved Hide resolved
changelog.d/358.misc Outdated Show resolved Hide resolved
sydent/replication/peer.py Outdated Show resolved Hide resolved
sydent/util/emailutils.py Outdated Show resolved Hide resolved
sydent/threepid/bind.py Outdated Show resolved Hide resolved
H-Shay added 2 commits June 15, 2021 11:51
Signed-off-by: H.Shay <shaysquared@gmail.com>
Copy link
Contributor

@callahad callahad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! More type hints!

@callahad callahad merged commit dcdca9c into matrix-org:main Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants