Allow configuration for disabling v1 bindings #267
Conversation
Add the 'enable_v1_associations' configuration flag to determine whether to enable or disable the creation of associations via v1 endpoints.
|
Any reason why we're only deprecating the associations-related endpoints instead of all of v1? |
Because logs show that some projects (namely mxisd) still do v1 lookups on our identity servers, and some old Riots still do status checks on the v1 endpoint (so cutting it off might break them entirely). It sure would be nice to cut all of the deprecated v1 endpoints off, but we'd need to be loud about that and allow a grace period for people to update before shutting them down entirely. |
|
There's no test because the current infrastructure doesn't allow to test that kind of things, but I did some manual testing on a local Sydent. Without # POST /requestToken
$ curl -d '{}' http://127.0.0.1:8090/_matrix/identity/api/v1/validate/email/requestToken
{"errcode": "M_MISSING_PARAMS", "error": "Missing parameters: email,client_secret,send_attempt"}
# POST /submitToken
$ curl -d '{}' http://127.0.0.1:8090/_matrix/identity/api/v1/validate/email/submitToken
{"errcode": "M_MISSING_PARAMS", "error": "Missing parameters: token,sid,client_secret"}
# GET /submitToken
$ curl http://127.0.0.1:8090/_matrix/identity/api/v1/validate/email/submitToken
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8" />
<title></title>
</head>
<body>
<p>Verification failed: you may need to request another verification email</p>
</body>
</html>
# POST /bind
$ curl -d '{}' http://127.0.0.1:8090/_matrix/identity/api/v1/3pid/bind
{"errcode": "M_MISSING_PARAMS", "error": "Missing parameters: sid,client_secret,mxid"}
$ With it set to # POST /requestToken
$ curl -d '{}' http://127.0.0.1:8090/_matrix/identity/api/v1/validate/email/requestToken
<html>
<head><title>404 - No Such Resource</title></head>
<body>
<h1>No Such Resource</h1>
<p>No such child resource.</p>
</body>
</html>
# POST /submitToken
$ curl -d '{}' http://127.0.0.1:8090/_matrix/identity/api/v1/validate/email/submitToken
<html>
<head><title>404 - No Such Resource</title></head>
<body>
<h1>No Such Resource</h1>
<p>No such child resource.</p>
</body>
</html>
# GET /submitToken
$ curl http://127.0.0.1:8090/_matrix/identity/api/v1/validate/email/submitToken
<html>
<head><title>404 - No Such Resource</title></head>
<body>
<h1>No Such Resource</h1>
<p>No such child resource.</p>
</body>
</html>
# POST /bind
$ curl -d '{}' http://127.0.0.1:8090/_matrix/identity/api/v1/3pid/bind
<html>
<head><title>404 - No Such Resource</title></head>
<body>
<h1>No Such Resource</h1>
<p>No such child resource.</p>
</body>
</html>
$ |
Add the 'enable_v1_associations' configuration flag to determine whether to enable or disable the creation of associations via v1 endpoints.