Remove : from allowed client_secret chars #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoadragon453
force-pushed
the
anoa/remove_colon_client_secret
branch
from
9236485
to
87df1bf
Compare
anoadragon453
added a commit
to matrix-org/synapse
that referenced
this pull request
Aug 18, 2020
Closes: #6766 Equivalent Sydent PR: matrix-org/sydent#309 I believe it's now time to remove the extra allowed `:` from `client_secret` parameters.
erikjohnston
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: matrix-org/synapse#6766
Equivalent Synapse PR: matrix-org/synapse#8101
I believe it's now time to remove the extra allowed
:fromclient_secretparameters.