Fix stack overflow triggered by casefolding script

changelog.d/405.bugfix

@@ -0,0 +1 @@
+Fix stack overflow caused by settign up logging multiple times in casefolding script.

scripts/casefold_db.py

@@ -407,7 +407,7 @@ def update_global_associations(
         sys.exit(1)
 
     sydent_config = SydentConfig()
-    sydent_config.parse_config_file(args.config_path)
+    sydent_config.parse_config_file(args.config_path, skip_logging_setup=True)
 
     reactor = ResolvingMemoryReactorClock()
     sydent = Sydent(sydent_config, reactor, False)

sydent/config/__init__.py

@@ -212,7 +212,9 @@ def parse_from_config_parser(self, cfg: ConfigParser) -> bool:
         """
         return self._parse_config(cfg)
 
-    def parse_config_file(self, config_file: str) -> None:
+    def parse_config_file(
+        self, config_file: str, skip_logging_setup: bool = False
+    ) -> None:
         """
         Parse the given config from a filepath, populating missing items and
         sections. NOTE: this method also sets up logging.
@@ -238,7 +240,8 @@ def parse_config_file(self, config_file: str) -> None:
 
         # Logging is configured in cfg, but these options must be parsed first
         # so that we can log while parsing the rest
-        setup_logging(cfg)
+        if not skip_logging_setup:
+            setup_logging(cfg)
 
         # TODO: Don't alter config file when starting Sydent so that
         #       it can be set to read-only

sydent/sydent.py

@@ -308,7 +308,7 @@ def run_gc():
 
 if __name__ == "__main__":
     sydent_config = SydentConfig()
-    sydent_config.parse_config_file(get_config_file_path())
+    sydent_config.parse_config_file(get_config_file_path(), skip_logging_setup=False)
 
     syd = Sydent(sydent_config)
     syd.run()