Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instructions to fix dependency name #549

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

felipeavilis
Copy link
Contributor

@felipeavilis felipeavilis commented Feb 22, 2023

When running apt-get to install dependencies, i got this message:

Package python-virtualenv is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'python-virtualenv' has no installation candidate

The package was installed using the name python3-virtualenv.

Pull Request Checklist

  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fix a bug that prevented receiving messages from other servers." instead of "Move X method from EventStore to EventWorkerStore.".
    • Include 'Contributed by Your Name.' or 'Contributed by @your-github-username.' — unless you would prefer not to be credited in the changelog.
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
  • Pull request includes a sign off

When running apt-get to install dependencies, i got this message:
    Package python-virtualenv is not available, but is referred to by another package.
    This may mean that the package is missing, has been obsoleted, or
    is only available from another source

    E: Package 'python-virtualenv' has no installation candidate

The package was installed using the name python3-virtualenv.
@felipeavilis felipeavilis requested a review from a team as a code owner February 22, 2023 15:01
@H-Shay
Copy link
Contributor

H-Shay commented Feb 23, 2023

Looks like you are missing a changelog file, would you mind adding one? Also forgive me if I missed it, but I don't see a signoff either.

Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per @H-Shay's review.

Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a trivial documentation change without any other way to fix it.

@clokep clokep changed the title Change package name Update installation instructions to fix dependency name Sep 6, 2023
@clokep clokep merged commit 5bc2d72 into matrix-org:main Sep 6, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants