Check if data["content"] is a dict before using it as a dict (#362)

matrix-org · Mar 21, 2024 · 0e98e55 · 0e98e55
1 parent 8a747a1
commit 0e98e55
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/362.bugfix b/changelog.d/362.bugfix
@@ -0,0 +1 @@
+Fix a bug causing Sygnal to fail when processing notifications without a `content` dict, when those notifications were destined for GCM. Contributed by @c-cal.
diff --git a/sygnal/gcmpushkin.py b/sygnal/gcmpushkin.py
@@ -669,7 +669,7 @@ def _build_data(
                     data[attr] = data[attr][0:MAX_BYTES_PER_FIELD]
 
         if api_version is APIVersion.V1:
-            if "content" in data:
+            if isinstance(data.get("content"), dict):
                 for attr, value in data["content"].items():
                     if not isinstance(value, str):
                         continue
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix a bug causing Sygnal to fail when processing notifications without a `content` dict, when those notifications were destined for GCM. Contributed by @c-cal.