Modernise tooling and fix CI failing #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMRobertson
force-pushed
the
dmr/modernize
branch
2 times, most recently
from
d1bc119
to
d66558b
Compare
|
Failing flake8 looks like this: python/importlib_metadata#406 :( |
|
This is an exc
Good spot, thank you. This is an excellent excuse for us to move to ruff instead of flake8. |
DMRobertson
force-pushed
the
dmr/modernize
branch
from
d66558b
to
8b21f0f
Compare
DMRobertson
force-pushed
the
dmr/modernize
branch
5 times, most recently
from
6cbfadf
to
24b06ea
Compare
clokep
reviewed
Apr 21, 2023
clokep
reviewed
Apr 21, 2023
|
There is one unit test failing. I can't obviously see why it's failing. |
Sorry. |
No worries. It's easily done, and was our fault for having broken CI. |
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
IDK we sometimes have to invoke trial explicitly like this
And remove py2-style type annotations, which ruff doesn't recognise Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
Needed for unit tests to be happy
DMRobertson
force-pushed
the
dmr/modernize
branch
from
73feb4f
to
afe3d2e
Compare
clokep
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commitwise reviewable.
I think the only necessary changes were
In particular, moving to pyproject.toml was my first attempt/guess to fix the CI errors, but I don't think it was strictly necessary.