This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Deal with Github Actions deprecation warnings #14203
Labels
A-CI
Issues related to CI on the Synapse repository
A-Testing
Issues related to testing in complement, synapse, etc
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Z-Future-Maintenance
Things that can't yet be done, but will need cleaning up in a couple of months/releases
Milestone
Comments
DMRobertson
added
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
good first issue
Good for newcomers
labels
Oct 17, 2022
See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ . No deadline as of yet. |
This comment was marked as resolved.
This comment was marked as resolved.
DMRobertson
added
A-Testing
Issues related to testing in complement, synapse, etc
and removed
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
labels
Oct 18, 2022
This comment was marked as resolved.
This comment was marked as resolved.
DMRobertson
added
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
and removed
good first issue
Good for newcomers
labels
Oct 18, 2022
This was referenced Oct 18, 2022
DMRobertson
added
the
Z-Future-Maintenance
Things that can't yet be done, but will need cleaning up in a couple of months/releases
label
Oct 18, 2022
There is also the removal of old macos runners that we use to build macos wheels. There are currently brownouts so we should bump this soon, otherwise it breaks building releases. |
DMRobertson
pushed a commit
to matrix-org/synapse-s3-storage-provider
that referenced
this issue
Oct 24, 2022
DMRobertson
pushed a commit
to matrix-org/synapse-s3-storage-provider
that referenced
this issue
Oct 24, 2022
DMRobertson
pushed a commit
to matrix-org/backend-meta
that referenced
this issue
Oct 24, 2022
DMRobertson
pushed a commit
to matrix-org/sliding-sync
that referenced
this issue
Mar 21, 2023
DMRobertson
pushed a commit
to matrix-org/sytest
that referenced
this issue
Apr 4, 2023
Part of matrix-org/synapse#14203 I've checked changelogs and AFAICS these are backwards compatible for our purposes. (There's a semver bump because a newer version of GHA runners and/or node.js is required. But we don't care about those.)
DMRobertson
pushed a commit
to matrix-org/synapse-s3-storage-provider
that referenced
this issue
Apr 4, 2023
DMRobertson
pushed a commit
to matrix-org/synapse-s3-storage-provider
that referenced
this issue
Apr 4, 2023
DMRobertson
pushed a commit
to matrix-org/sytest
that referenced
this issue
Apr 4, 2023
Part of matrix-org/synapse#14203 I've checked changelogs and AFAICS these are backwards compatible for our purposes. (There's a semver bump because a newer version of GHA runners and/or node.js is required. But we don't care about those.)
DMRobertson
pushed a commit
to matrix-org/complement
that referenced
this issue
Apr 6, 2023
Drive-by fix for matrix-org/synapse#14203
DMRobertson
pushed a commit
to matrix-org/complement
that referenced
this issue
Apr 6, 2023
Drive-by fix for matrix-org/synapse#14203
DMRobertson
pushed a commit
to matrix-org/complement
that referenced
this issue
Apr 6, 2023
* Use setup-go action This was my first attempt to fix CI. Go 1.17 is no longer available on runners (actions/runner-images#7276 maybe) and I wondered if that might help with that. Unfortunately I think not. But we should get some go build caching as a side effect of using this action. * Bump checkout action Drive-by fix for matrix-org/synapse#14203 * Check that gotestfmt is installed no `-version` flag, so `help` will have to do * `go install gotestfmt` instead of `go get` IDK why this suddenly started failing, but `go install` seems to put it on the PATH in a way that makes CI work.
DMRobertson
pushed a commit
to matrix-org/sygnal
that referenced
this issue
Apr 21, 2023
DMRobertson
pushed a commit
to matrix-org/sygnal
that referenced
this issue
Apr 21, 2023
DMRobertson
pushed a commit
to matrix-org/sygnal
that referenced
this issue
Apr 21, 2023
DMRobertson
pushed a commit
to matrix-org/sygnal
that referenced
this issue
Apr 21, 2023
DMRobertson
pushed a commit
to matrix-org/sygnal
that referenced
this issue
Apr 21, 2023
DMRobertson
pushed a commit
to matrix-org/sygnal
that referenced
this issue
Apr 21, 2023
DMRobertson
pushed a commit
to matrix-org/sygnal
that referenced
this issue
Apr 21, 2023
DMRobertson
pushed a commit
to matrix-org/sygnal
that referenced
this issue
Apr 21, 2023
DMRobertson
pushed a commit
to matrix-org/sygnal
that referenced
this issue
Apr 21, 2023
* Move from setup.py to pyproject.toml Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Ensure unit tests run IDK we sometimes have to invoke trial explicitly like this * Use ruff instead of flake8 And remove py2-style type annotations, which ruff doesn't recognise Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Bump GHA actions part of matrix-org/synapse#14203 * Run black Presumably this fixes complaints from #333 and #334 * Move isort config to pyproject * Also lint stubs * Bump GHA actions part of matrix-org/synapse#14203 * Fix an unintended rename in #333 Needed for unit tests to be happy * Changelog --------- Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
This was referenced May 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A-CI
Issues related to CI on the Synapse repository
A-Testing
Issues related to testing in complement, synapse, etc
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Z-Future-Maintenance
Things that can't yet be done, but will need cleaning up in a couple of months/releases
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
See e.g. https://github.com/matrix-org/synapse/actions/runs/3258600088 (and likely other workflows too)
Node.js 12 actions,
save-state
andset-output
are all "deprecated and will be disabled soon".PRs:
GITHUB_OUTPUT
in CI backend-meta#13 and the follow-up matrix-org/backend-meta@1a8479cThe text was updated successfully, but these errors were encountered: