Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with GHA deprecation warnings #9

Closed
DMRobertson opened this issue May 11, 2023 · 3 comments
Closed

Deal with GHA deprecation warnings #9

DMRobertson opened this issue May 11, 2023 · 3 comments

Comments

@DMRobertson
Copy link

DMRobertson commented May 11, 2023

See matrix-org/synapse#14203 for more context.

The warnings I have in mind are e.g. https://github.com/matrix-org/synapse/actions/runs/4936859583

There are two categories of warnings. First:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16:

  • actions/github-script@v5

That comes from matrix-org/pr-details-action@v1.1. The warning should be fixed by #5, which pulls in matrix-org/pr-details-action#4.

Merging #8 should fix this, which pulls in nwtgck/actions-netlify#847.

Second:

The set-output command is deprecated and will be disabled soon.

https://github.com/matrix-org/synapse/actions/runs/4936859583/jobs/8824910967#step:3:30 is probably the easiest way to see where these come from.

I am happy to do this.

@DMRobertson
Copy link
Author

I am happy to do this.

I was going to PR the changes, but I think merging #5, #7, #8 should fix this. @t3chguy would it be possible to merge those and release a new version of this action? (If it's any easier, I'm happy to do so if you prefer and are willing to grant me write access to the repository.)

@t3chguy
Copy link
Member

t3chguy commented May 11, 2023

@DMRobertson https://github.com/matrix-org/netlify-pr-preview/releases/tag/v2

@DMRobertson
Copy link
Author

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants