-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch all PRs and search in the result #4
Fetch all PRs and search in the result #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs pagination support otherwise will only work for the latest ~50 PRs iirc
As far as I understand the doc |
Oh yes, the lack of syntax highlight made me miss that call somehow. Do you have a test run of this somewhere? |
If that is the case then we have the other issue of that dataset growing forever unbounded, and eventually hitting the limit on the GITHUB_TOKEN. So we should only paginate when the previous page did not contain our result. |
For some reason a query with the head param does not always return a result. Fetching all PRs return these as well. So we fetch all and then iterate the results to find the PR we are looking for.
1c7d8a7
to
9d140e3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me
So you haven't tested a version of this action using the code though to verify it end-to-end? You can specify action versions by git sha to refer to your unmerged code as version |
Updated to v6. Test run here: https://github.com/weeman1337/matrix-react-sdk/runs/7411468006?check_suite_focus=true |
Fixes not finding some PRs such as matrix-org/matrix-react-sdk#9002
For some reason a query with the head param does not always return a
result. Fetching all PRs return these as well. So we fetch all and then
iterate the results to find the PR we are looking for.