Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix source of noise in tests in test_apns.py. #149

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Fix source of noise in tests in test_apns.py. #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/149.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove a source of nuisance, noisy (but otherwise harmless) exceptions in tests.
4 changes: 2 additions & 2 deletions tests/test_apns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def test_payload_truncation(self):
"""
# Arrange
method = self.apns_pushkin_snotif
method.return_value = testutils.make_async_magic_mock(
method.side_effect = testutils.make_async_magic_mock(
NotificationResult("notID", "200")
)
self.sygnal.pushkins[PUSHKIN_ID].MAX_JSON_BODY_SIZE = 240
Expand All @@ -91,7 +91,7 @@ def test_payload_truncation_test_validity(self):
"""
# Arrange
method = self.apns_pushkin_snotif
method.return_value = testutils.make_async_magic_mock(
method.side_effect = testutils.make_async_magic_mock(
NotificationResult("notID", "200")
)
self.sygnal.pushkins[PUSHKIN_ID].MAX_JSON_BODY_SIZE = 4096
Expand Down