Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup Sygnal version using the correct name #355

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Conversation

DMRobertson
Copy link
Contributor

@DMRobertson DMRobertson commented Nov 21, 2023

We passed it a module name 1 instead of the "distribution name"(?)

Broken in 0ced8bd, so Sygnal 0.5.0.

Fixes #354.

David Robertson added 2 commits November 21, 2023 15:37
We passed it a module name [1] instead of the "distribution name"(?)

Broken in 0ced8bd, so Sygnal 0.5.0.

[1]: https://docs.python.org/3/reference/import.html#name__
@DMRobertson DMRobertson marked this pull request as ready for review November 21, 2023 16:08
@DMRobertson DMRobertson requested a review from a team as a code owner November 21, 2023 16:08
@DMRobertson DMRobertson merged commit 5f55f42 into main Nov 21, 2023
5 checks passed
@DMRobertson DMRobertson deleted the dmr/fix-version branch November 21, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sygnal.__version__ is broken
2 participants