Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a docker file #63

Merged
merged 6 commits into from
May 12, 2020
Merged

Add a docker file #63

merged 6 commits into from
May 12, 2020

Conversation

hawkowl
Copy link
Contributor

@hawkowl hawkowl commented Sep 24, 2019

No description provided.

@hawkowl hawkowl requested a review from a team September 24, 2019 02:22
erikjohnston
erikjohnston previously approved these changes Sep 24, 2019
View reviewed changes
docker/Dockerfile Outdated Show resolved Hide resolved
@richvdh richvdh mentioned this pull request Mar 25, 2020
Closed
ghost
ghost reviewed Apr 29, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a few changes to make it compatible with latest version. This file works for me but I have not tested PostgreSQL support.

docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
@Half-Shot Half-Shot self-assigned this May 12, 2020
@Half-Shot Half-Shot requested a review from clokep May 12, 2020 16:54
@clokep
Copy link
Member

clokep commented May 12, 2020

@Half-Shot I think this needs a master merged in -- there are conflicts.

@Half-Shot Half-Shot requested review from a team and removed request for clokep May 12, 2020 17:07
anoadragon453
anoadragon453 requested changes May 12, 2020
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get a cryptic docker networking error when trying to build the container which I believe is unrelated:

Sending build context to Docker daemon  153.2MB
Step 1/9 : FROM python:3.7-slim as builder
 ---> d7ee20941226
Step 2/9 : RUN apt-get update && apt-get install -y gcc git libpq-dev
 ---> Running in 468b9a3c4186
failed to create endpoint boring_ptolemy on network bridge: failed to add the host (vethebbff49) <=> sandbox (vethbe2b839) pair interfaces: operation not supported

So assuming it builds and starts for you, this PR looks good other than the small fixes below.

MANIFEST.in Outdated Show resolved Hide resolved
MANIFEST.in Outdated Show resolved Hide resolved
changelog.d/63.misc Outdated Show resolved Hide resolved
@Half-Shot @anoadragon453
Apply suggestions from code review
5762926 
Bleh

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@Half-Shot Half-Shot merged commit 37a067d into master May 12, 2020
@Half-Shot Half-Shot deleted the hawkowl/dockerfile branch May 12, 2020 17:34
@Half-Shot Half-Shot mentioned this pull request May 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

@erikjohnston erikjohnston erikjohnston left review comments

Assignees

@Half-Shot Half-Shot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hawkowl @clokep @anoadragon453 @erikjohnston @Half-Shot