Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for release: Update version 1.1.1 -> 1.1.2 #16

Merged
merged 4 commits into from
May 23, 2023
Merged

Prepare for release: Update version 1.1.1 -> 1.1.2 #16

merged 4 commits into from
May 23, 2023

Conversation

H-Shay
Copy link
Contributor

@H-Shay H-Shay commented May 16, 2023

No description provided.

@H-Shay H-Shay requested a review from a team as a code owner May 16, 2023 20:28
@clokep
Copy link
Member

clokep commented May 17, 2023

The test failure seems real? It is complaining about using something which is not exported, which for the module API seems bad.

@H-Shay
Copy link
Contributor Author

H-Shay commented May 17, 2023

The mypy failure is from #15. This PR uses run_as_background_process which was explicitly exported in matrix-org/synapse#15577, but mypy will not pick up on this explicit export until a new version of synapse is released.

@clokep
Copy link
Member

clokep commented May 17, 2023

We should probably update the readme for the minimum version of Synapse this supports?

@H-Shay
Copy link
Contributor Author

H-Shay commented May 17, 2023 •
edited
Loading

We should probably update the readme for the minimum version of Synapse this supports?

Good point I hadn't thought of that - although the code will run fine on older versions of Synapse, you'll just get the weird mypy failure if you run the lints. Is it worth mentioning that?

@H-Shay
Copy link
Contributor Author

H-Shay commented May 17, 2023

I've bumped the compatible version in the readme and setup.cfg, predictably everything fails now as synapse v1.84.0 is not available until tuesday - I am assuming I should just leave this on ice until then.

@clokep
Copy link
Member

clokep commented May 18, 2023

@H-Shay I think you checked your virtualenv in.

@H-Shay
Copy link
Contributor Author

H-Shay commented May 18, 2023

Fixed it, thank you for pointing it out.

@H-Shay
Copy link
Contributor Author

H-Shay commented May 23, 2023

The CI is now green on this, any objections to me merging and releasing?

@H-Shay H-Shay merged commit 1634053 into main May 23, 2023
@H-Shay H-Shay deleted the shay/bump_version branch May 23, 2023 18:47
@H-Shay
Copy link
Contributor Author

H-Shay commented May 23, 2023

Merged #16 into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMRobertson DMRobertson DMRobertson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@H-Shay @clokep @DMRobertson