Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Call out buildkit is required when building test docker images (#13338)
Browse files Browse the repository at this point in the history
Co-authored-by: David Robertson <davidr@element.io>
  • Loading branch information
babolivier and David Robertson committed Jul 21, 2022
1 parent 34949ea commit 10e4093
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions changelog.d/13338.doc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Mention that BuildKit is needed when building Docker images for tests.
1 change: 1 addition & 0 deletions docker/Dockerfile-workers
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# syntax=docker/dockerfile:1
# Inherit from the official Synapse docker image
ARG SYNAPSE_VERSION=latest
FROM matrixdotorg/synapse:$SYNAPSE_VERSION
Expand Down
4 changes: 4 additions & 0 deletions docker/README-testing.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ Consult the [contributing guide][guideComplementSh] for instructions on how to u
Under some circumstances, you may wish to build the images manually.
The instructions below will lead you to doing that.

Note that these images can only be built using [BuildKit](https://docs.docker.com/develop/develop-images/build_enhancements/),
therefore BuildKit needs to be enabled when calling `docker build`. This can be done by
setting `DOCKER_BUILDKIT=1` in your environment.

Start by building the base Synapse docker image. If you wish to run tests with the latest
release of Synapse, instead of your current checkout, you can skip this step. From the
root of the repository:
Expand Down
1 change: 1 addition & 0 deletions docker/complement/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# syntax=docker/dockerfile:1
# This dockerfile builds on top of 'docker/Dockerfile-workers' in matrix-org/synapse
# by including a built-in postgres instance, as well as setting up the homeserver so
# that it is ready for testing via Complement.
Expand Down

0 comments on commit 10e4093

Please sign in to comment.