Fix wrong arguments being passed to BlacklistingAgentWrapper (#9098)

A reactor was being passed instead of a whitelist for the BlacklistingAgentWrapper used by the WellyKnownResolver. This coulld cause exceptions when attempting to connect to IP addresses that are blacklisted, but in reality this did not have any observable affect since this code is not used for IP literals.
matrix-org · Jan 14, 2021 · 12702be · 12702be
1 parent 233c8b9
commit 12702be
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/changelog.d/9098.misc b/changelog.d/9098.misc
@@ -0,0 +1 @@
+Fix the wrong arguments being passed to `BlacklistingAgentWrapper` from `MatrixFederationAgent`. Contributed by Timothy Leung.
diff --git a/synapse/http/federation/matrix_federation_agent.py b/synapse/http/federation/matrix_federation_agent.py
@@ -102,7 +102,6 @@ def __init__(
                         pool=self._pool,
                         contextFactory=tls_client_options_factory,
                     ),
-                    self._reactor,
                     ip_blacklist=ip_blacklist,
                 ),
                 user_agent=self.user_agent,