Improve comments in the structured logging code. (#10188)

matrix-org · Jun 16, 2021 · 18edc9a · 18edc9a
1 parent 76f9c70
commit 18edc9a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/changelog.d/10188.misc b/changelog.d/10188.misc
@@ -0,0 +1 @@
+Improve comments in structured logging code.
diff --git a/synapse/logging/_terse_json.py b/synapse/logging/_terse_json.py
@@ -20,8 +20,9 @@
 
 _encoder = json.JSONEncoder(ensure_ascii=False, separators=(",", ":"))
 
-# The properties of a standard LogRecord.
-_LOG_RECORD_ATTRIBUTES = {
+# The properties of a standard LogRecord that should be ignored when generating
+# JSON logs.
+_IGNORED_LOG_RECORD_ATTRIBUTES = {
     "args",
     "asctime",
     "created",
@@ -59,9 +60,9 @@ def format(self, record: logging.LogRecord) -> str:
         return self._format(record, event)
 
     def _format(self, record: logging.LogRecord, event: dict) -> str:
-        # Add any extra attributes to the event.
+        # Add attributes specified via the extra keyword to the logged event.
         for key, value in record.__dict__.items():
-            if key not in _LOG_RECORD_ATTRIBUTES:
+            if key not in _IGNORED_LOG_RECORD_ATTRIBUTES:
                 event[key] = value
 
         return _encoder.encode(event)