Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Add missing dependency on importlib_metadata
Browse files Browse the repository at this point in the history
Missed in #12088. We got away with it because we were indirectly
requiring it via other packages.

Without this change, we encounter pain in `poetry export`; and besides,
we should be explicit about our direct dependencies.
  • Loading branch information
David Robertson committed Apr 5, 2022
1 parent 70195e4 commit 2f8ec8d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,9 @@ ijson = ">=3.1.4"
matrix-common = "~=1.1.0"
# We need packaging.requirements.Requirement, added in 16.1.
packaging = ">=16.1"
# At the time of writing, we only use functions from the version `importlib.metadata`
# which shipped in Python 3.8. This corresponds to version 1.4 of the backport.
importlib_metadata = { version = ">=1.4", python = "<3.8" }


# Optional Dependencies
Expand Down
3 changes: 3 additions & 0 deletions synapse/python_dependencies.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@
"matrix-common~=1.1.0",
# We need packaging.requirements.Requirement, added in 16.1.
"packaging>=16.1",
# At the time of writing, we only use functions from the version `importlib.metadata`
# which shipped in Python 3.8. This corresponds to version 1.4 of the backport.
"importlib_metadata>=1.4; python_version < 3.8",
]

CONDITIONAL_REQUIREMENTS = {
Expand Down

0 comments on commit 2f8ec8d

Please sign in to comment.