Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Update out-of-date-comment
Browse files Browse the repository at this point in the history
#9189 makes this comment redundant.
  • Loading branch information
richvdh committed Jan 21, 2021
1 parent 69e5e2c commit ac3d44d
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions synapse/config/oidc_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,9 @@ def read_config(self, config, **kwargs):
except DependencyException as e:
raise ConfigError(e.message) from e

# check we don't have any duplicate idp_ids
# XXX: this won't detect clashes with other IdP providers using other SSO
# mechanisms (such as SAML or CAS); that will be detected when we set up the
# listeners but by then synapse will have forked, so it's not ideal.
# check we don't have any duplicate idp_ids now. (The SSO handler will also
# check for duplicates when the REST listeners get registered, but that happens
# after synapse has forked so doesn't give nice errors.)
c = Counter([i.idp_id for i in self.oidc_providers])
for idp_id, count in c.items():
if count > 1:
Expand Down

0 comments on commit ac3d44d

Please sign in to comment.