Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Relax version guard for packaging (#12166)
Browse files Browse the repository at this point in the history
It’s just occurred to me that #12088 pulled in the “packaging” package (~=21.3). I pulled in the newest version I had at the time.

I only use it for packaging.requirements.Requirements. Which was added in packaging 16.1: https://github.com/pypa/packaging/releases/tag/16.1

https://pkgs.org/download/python3-packaging suggests that the oldest version we care about is 17.1 in Ubuntu Bionic. So I think with this bound we're hunky dory.
  • Loading branch information
David Robertson authored Mar 4, 2022
1 parent cea1b58 commit d2ef1a7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions changelog.d/12166.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Relax the version guard for "packaging" added in #12088.
4 changes: 2 additions & 2 deletions synapse/python_dependencies.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@
# ijson 3.1.4 fixes a bug with "." in property names
"ijson>=3.1.4",
"matrix-common~=1.1.0",
# For runtime introspection of our dependencies
"packaging~=21.3",
# We need packaging.requirements.Requirement, added in 16.1.
"packaging>=16.1",
]

CONDITIONAL_REQUIREMENTS = {
Expand Down

0 comments on commit d2ef1a7

Please sign in to comment.