Ensure that event.redacts is the proper type before handling it (#8457)

This fixes a bug when backfilling invalid events.
matrix-org · Oct 5, 2020 · da11cc2 · da11cc2
1 parent 0991a2d
commit da11cc2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/changelog.d/8457.bugfix b/changelog.d/8457.bugfix
@@ -0,0 +1 @@
+Fix a bug where backfilling a room with an event that was missing the `redacts` field would break.
diff --git a/synapse/event_auth.py b/synapse/event_auth.py
@@ -446,6 +446,8 @@ def check_redaction(
 
     if room_version_obj.event_format == EventFormatVersions.V1:
         redacter_domain = get_domain_from_id(event.event_id)
+        if not isinstance(event.redacts, str):
+            return False
         redactee_domain = get_domain_from_id(event.redacts)
         if redacter_domain == redactee_domain:
             return True
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix a bug where backfilling a room with an event that was missing the `redacts` field would break.